From cb8bf6540ce5541aa236b7ab2f4158cf55d7fae9 Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Fri, 23 Oct 2020 12:27:55 -0400 Subject: [PATCH] editablelabel: Properly clean up in dispose Unparenting the stack finalizes the entry and label, but at least the label is available via the gtk_editable_get_delegate API, and the a11y implementation uses that at dispose time. So, clear the pointers to prevent them from being dangling. This was showing up as a segfault of the doc-shooter. --- gtk/gtkeditablelabel.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gtk/gtkeditablelabel.c b/gtk/gtkeditablelabel.c index 959d0428d8..103b125649 100644 --- a/gtk/gtkeditablelabel.c +++ b/gtk/gtkeditablelabel.c @@ -341,6 +341,9 @@ gtk_editable_label_dispose (GObject *object) g_clear_pointer (&self->stack, gtk_widget_unparent); + self->entry = NULL; + self->label = NULL; + G_OBJECT_CLASS (gtk_editable_label_parent_class)->dispose (object); } -- 2.30.2